Skip to content

Fix concurrency issue for update/delete commands when using filters #2712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 31, 2021
Merged

Fix concurrency issue for update/delete commands when using filters #2712

merged 1 commit into from
Mar 31, 2021

Conversation

maca88
Copy link
Contributor

@maca88 maca88 commented Mar 28, 2021

Fix a regression introduced by #1931, which modified the cached parameter specifications on every update/delete command.

Fixes #2710

@fredericDelaporte fredericDelaporte added this to the 5.3.8 milestone Mar 28, 2021
@gokhanabatay
Copy link
Contributor

@maca88, @fredericDelaporte when dou you plan to release dev build, it's critical production issue for us.

@fredericDelaporte fredericDelaporte merged commit f832a97 into nhibernate:5.3.x Mar 31, 2021
@fredericDelaporte fredericDelaporte mentioned this pull request Mar 31, 2021
Closed
@fredericDelaporte
Copy link
Member

fredericDelaporte commented Apr 1, 2021 •
edited
Loading

There is a dev build for 5.3.8 on myget now.

@gokhanabatay
Copy link
Contributor

@fredericDelaporte "5.4.0-dev.3319" does not include this fix still getting error

There is a dev build for 5.3.8 on myget now.

@bahusoid
Copy link
Member

bahusoid commented Apr 2, 2021

There is a dev build for 5.3.8
"5.4.0-dev.3319" does not include this fix

And why do you check 5.4 dev version?
https://www.myget.org/feed/nhibernate/package/nuget/NHibernate/5.3.8-dev.3324

@gokhanabatay
Copy link
Contributor

We thought

There is a dev build for 5.3.8
"5.4.0-dev.3319" does not include this fix

And why do you check 5.4 dev version?
https://www.myget.org/feed/nhibernate/package/nuget/NHibernate/5.3.8-dev.3324

We were using the latest version with the idea that the master branch(dev latest nightly build) contains the latest improvements and bug fixes, is that wrong?

@bahusoid
Copy link
Member

bahusoid commented Apr 2, 2021

Regressions are firstly landed to affected branches and only after release they merged to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fredericDelaporte fredericDelaporte fredericDelaporte approved these changes

Assignees

No one assigned

Labels

r: Fixed t: Fix

Projects

None yet

Milestone

5.3.8

Development

Successfully merging this pull request may close these issues.

4 participants

@maca88 @gokhanabatay @fredericDelaporte @bahusoid